-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scope css sibling combinator #5427
Conversation
9fc4d48
to
cd6a9b3
Compare
What are the new |
ok the gist of what I'm trying to do here is that, for example: <div id="a" />
<div id="b" />
{#each foo}
<div id="c" />
{/each}
<div id="d" />
so both however, for another example: <div id="a" />
{#each foo}
<div id="b" />
{:else}
<div id="c" />
{/each}
<div id="d" />
so both |
i've tried to come up with test cases with different nested logic blocks:
here hopefully im able to cover all of the edge cases 😅 |
@tanhauhau Hi, this PR broke selectors like this one: :global(*) + .button.margin {
margin-top: 8px;
} They are getting stripped despite global. I used them in Repro: https://svelte.dev/repl/5ec4d420b4b44ea4b441da24010d8acd?version=3.26.0 |
Implement css scoping for
~
and+
css sibling combinatorFixes #3104
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint